The idea behind the life insurance was that by starting it early (when we were 2, 4, 5, and 8) it would continue to grow so that by the time we were old enough to be buying houses, be married, have kids, we would have it as an asset. At the time they may have been jumping the gun, but 25 years later, it's a great thing for us to have.
Dad would buy stocks in companies we were familiar with like you said - Disney, Pepsi, McDonalds etc.
Obviously I'm not saying the idea of putting the money somewhere early like that was bad and I don't think they jumped the gun at all - just that the vehicle chosen was probably the worst possible (who's knows, maybe regular savings at some low % may have been worse, although those high rates in the early 80's could have compensated for the low rates later on). I can't run the numbers as I don't have appropriate information but over 25 years, almost anything else would be better.
As opposed to doing nothing, however, it's not horrible.